Review Request: Fix crash on File->New in words

Boudewijn Rempt boud at valdyas.org
Sun Aug 7 09:32:44 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102240/#review5477
-----------------------------------------------------------

Ship it!


When it gets this complicated, better move the implementation to the cpp file, instead of the header, apart from that, ship it!

- Boudewijn


On Aug. 7, 2011, 9:07 a.m., Peter Simonsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102240/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2011, 9:07 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> The RDF docker causes a crash on File->New because it doesn't clean up correctly when the canvas disappear.
> 
> 
> Diffs
> -----
> 
>   words/part/dockers/KWRdfDocker.h 0396d5a 
> 
> Diff: http://git.reviewboard.kde.org/r/102240/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110807/422ccc98/attachment-0001.html>


More information about the calligra-devel mailing list