Review Request: Clean up the tool options widgets

Peter Simonsson peter.simonsson at gmail.com
Sat Aug 6 19:23:47 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102234/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

KarbonCalligraphyOptionWidget:
KarbonPencilTool:
KoZoomToolWidget:
TreeShapeConfigWidget:
Add stretch to make it look good on big screens

KoToolBase:
Don't add a generic window title in the default implementation of createOptionWidgets as it only duplicates what the docker header says

KoPathTool:
DefaultTool:
Don't first create snapguide widget and set a window title and then create a new snapguide widget and add that to the list of widgets to return

KoToolDocker:
Handle empty window titles while creating the layout

ReviewTool:
Don't try to set a layout on a widget that already has a layout


Diffs
-----

  karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.cpp 0ce337d 
  karbon/plugins/tools/KarbonPencilTool.cpp 86c8fa5 
  libs/flake/KoToolBase.cpp 77c039d 
  libs/flake/tools/KoPathTool.cpp 361324e 
  libs/flake/tools/KoZoomToolWidget.ui ed3ba73 
  libs/main/KoToolDocker.cpp 78c881a 
  plugins/defaultTools/defaulttool/DefaultTool.cpp f54ddd3 
  plugins/textshape/ReviewTool.cpp 8a1c88c 
  plugins/treeshape/TreeShapeConfigWidget.ui e7e367f 

Diff: http://git.reviewboard.kde.org/r/102234/diff


Testing
-------


Thanks,

Peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110806/57154f90/attachment.htm>


More information about the calligra-devel mailing list