Review Request: Added an undo stack parameter to KoDocument

Boudewijn Rempt boud at valdyas.org
Wed Aug 3 15:33:55 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102196/#review5348
-----------------------------------------------------------

Ship it!



libs/main/KoDocument.h
<http://git.reviewboard.kde.org/r/102196/#comment4836>

    I don't think the apidox are really clear -- apart from that, it's fine.


- Boudewijn


On Aug. 3, 2011, 2:17 p.m., Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102196/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2011, 2:17 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> The clients should be able to choose which type of undo stack they are going to use. I've made KUndo2Stack polymorphic in my branch, so now i need to be able to create my own undo stack for Krita. We can't use a factory method pattern here, because the stack should be created in the constructor.
> 
> 
> This addresses bug 277736.
>     http://bugs.kde.org/show_bug.cgi?id=277736
> 
> 
> Diffs
> -----
> 
>   libs/main/KoDocument.h 63e4ebf 
>   libs/main/KoDocument.cpp 515911a 
> 
> Diff: http://git.reviewboard.kde.org/r/102196/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110803/f55dce3e/attachment.htm>


More information about the calligra-devel mailing list