Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

Yue Liu opuspace at gmail.com
Wed Aug 3 09:08:40 BST 2011



> On Aug. 3, 2011, 7:40 a.m., Boudewijn Rempt wrote:
> > libs/flake/KoShapeGroup.cpp, line 63
> > <http://git.reviewboard.kde.org/r/102072/diff/4/?file=30652#file30652line63>
> >
> >     Please check that this patch doesn't regress on bug 227512 and the things described in https://svn.reviewboard.kde.org/r/5231/ and https://svn.reviewboard.kde.org/r/5253/. You need to test in Krita for that, I'm afraid.

I've tested in Krita. The position change bug is solved. It is the calling of boundingRect in method shapeCountChanged() caused that bug.


- Yue


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102072/#review5332
-----------------------------------------------------------


On Aug. 3, 2011, 7:20 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102072/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2011, 7:20 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeContainer.cpp e7585ec 
>   libs/flake/KoShapeGroup.h 5ccd574 
>   libs/flake/KoShapeGroup.cpp aaa58b4 
>   libs/flake/KoShapeShadow.h 07c760c 
>   libs/flake/KoShapeShadow.cpp 5485b19 
>   libs/flake/tests/TestShapeGroupCommand.cpp 397c17b 
>   libs/widgets/KoShadowConfigWidget.cpp 1a41042 
>   plugins/dockers/shadowdocker/ShadowDocker.cpp ef53fae 
> 
> Diff: http://git.reviewboard.kde.org/r/102072/diff
> 
> 
> Testing
> -------
> 
> http://my.cdash.org/viewTest.php?onlydelta&buildid=212010
> 
> 
> Screenshots
> -----------
> 
> groupshadow / shape shadow
>   http://git.reviewboard.kde.org/r/102072/s/210/
> 
> 
> Thanks,
> 
> Yue
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110803/2e362bf5/attachment.htm>


More information about the calligra-devel mailing list