Review Request: The basic web widget in Kexi reports, put up for review.The widget is not yet painted on report canvas.Please suggest possible issues

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102046/#review5327
-----------------------------------------------------------



plugins/reporting/web/KoReportDesignerItemweb.h
<http://git.reviewboard.kde.org/r/102046/#comment4814>

    This doesnt match the implementation



plugins/reporting/web/KoReportItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4816>

    not needed



plugins/reporting/web/KoReportItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4815>

    does this compile? how about just m_view = new QWebView(0) ?



plugins/reporting/web/KoReportItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4817>

    added the control source property twice



plugins/reporting/web/KoReportItemweb.cpp
<http://git.reviewboard.kde.org/r/102046/#comment4818>

    before the web view is rendered, you will want to load the url specified in 'data'.  Probably synchronously too, unless a way can be thought of to do it async



plugins/reporting/web/koreport_webplugin.desktop
<http://git.reviewboard.kde.org/r/102046/#comment4819>

    Once i made various changes to get it to compile, it did indeed show as a button in the report item list.


- Adam


On July 30, 2011, 9:38 a.m., Shreya Pandit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102046/
> -----------------------------------------------------------
> 
> (Updated July 30, 2011, 9:38 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Summary
> -------
> 
> Web widget for reports.Please suggest changes
> 
> 
> This addresses bug no.
>     http://bugs.kde.org/show_bug.cgi?id=no
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/web/KoReportwebPlugin.h PRE-CREATION 
>   plugins/reporting/web/KoReportwebPlugin.cpp PRE-CREATION 
>   plugins/reporting/web/KoReportItemweb.cpp PRE-CREATION 
>   plugins/reporting/web/KoReportDesignerItemweb.h PRE-CREATION 
>   plugins/reporting/web/KoReportItemweb.h PRE-CREATION 
>   plugins/reporting/web/koreport_webplugin.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102046/diff
> 
> 
> Testing
> -------
> 
> built
> 
> 
> Thanks,
> 
> Shreya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110802/03623b5c/attachment.htm>