Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

[Jan Hambrecht]

> On July 31, 2011, 9:37 p.m., Jan Hambrecht wrote:
> > I just tested your code, looks good so far. Regarding the painting artifacts while moving, I think these are caused by not taking the blur radius into account when calculating the insets of the shadow.
> 
> Yue Liu wrote:
>     Blur radius is not in insets, but I adjusted the QRectF later when painting, or the update of canvas is only decided by insets?

Yes it needs to be included in the insets calculation, otherwise how would the painting code know to calculate the update rect of a shape with a shadow correctly?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102072/#review5288
-----------------------------------------------------------


On July 29, 2011, 3:47 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102072/
> -----------------------------------------------------------
> 
> (Updated July 29, 2011, 3:47 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeGroup.h 5ccd57406ed46bf2dc443bc80df90621011b4a05 
>   libs/flake/KoShapeGroup.cpp aaa58b4413f7d8bd10d0805c733cd3799052a886 
>   libs/flake/KoShapeShadow.h 07c760c4cecd3050ecd6af9c4040c2f859242abe 
>   libs/flake/KoShapeShadow.cpp 5485b19109a179845e0b17827025a5c64d378221 
>   libs/widgets/KoShadowConfigWidget.cpp 1a410421831aec2e1668bb82c65d652f6c6fdbd1 
>   plugins/dockers/shadowdocker/ShadowDocker.cpp ef53fae66ef2f4910eb13726ee9621a4a98c83e3 
> 
> Diff: http://git.reviewboard.kde.org/r/102072/diff
> 
> 
> Testing
> -------
> 
> http://my.cdash.org/viewTest.php?onlydelta&buildid=212010
> 
> 
> Screenshots
> -----------
> 
> groupshadow / shape shadow
>   http://git.reviewboard.kde.org/r/102072/s/210/
> 
> 
> Thanks,
> 
> Yue
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/9ed7a91b/attachment.htm>