Review Request: Untangle KoToolSelection and KoTextEditor

Casper Boemann cbr at boemann.dk
Mon Aug 1 10:31:42 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102168/#review5295
-----------------------------------------------------------


it looks fine to me, anyone with objections?

- Casper


On Aug. 1, 2011, 9:07 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102168/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2011, 9:07 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> KoTextEditor used to be KoTextSelectionHandler and back then was ties to KoToolSelection. KoToolSelection was meant to allow access to the selection the tool handles inside the shape data, not to allow edit access to the entire data inside the shape. KoTextEditor was refactored to belong to the QTextDocument inside a text shape and be a generic editing interface. 
> 
> This patch takes the initial refactoring further along and removes the connection between KoToolSelection and KoTextEditor by adding a new TextToolSelection class that proxies for to KoTextEditor::hasSelection, but doesn't return the KoTextEditor of the document the tool is acting on.
> 
> Instead, it's now possible to query the canvas for the currently selected shapes, check whether one of those shapes has a KoTextShapeDataBase and then return the associated KoTextEditor for that, following Pierre's idea of making KoTextEditor associated not with the current tool but with the shapes.
> 
> (For the patches individually, see my mail to the mailing list)
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoToolProxy.h ced32ac 
>   libs/flake/KoToolProxy.cpp 3576b78 
>   libs/kotext/InsertInlineObjectActionBase.cpp 9647a56 
>   libs/kotext/InsertTextLocator.cpp 2195a02 
>   libs/kotext/KoTextDocument.h f74a9bd 
>   libs/kotext/KoTextEditor.h 02d0ef1 
>   libs/kotext/KoTextEditor.cpp 70c421d 
>   libs/main/rdf/InsertSemanticObjectActionBase.h 28b0b83 
>   libs/main/rdf/InsertSemanticObjectActionBase.cpp cc37e4c 
>   libs/main/rdf/KoDocumentRdf.h 676c84c 
>   libs/main/rdf/KoDocumentRdf.cpp b9d2525 
>   libs/main/rdf/KoDocumentRdfEditWidget.cpp 6114daa 
>   libs/main/rdf/KoRdfSemanticItem.cpp c92634e 
>   libs/main/rdf/KoRdfSemanticItemViewSite.cpp 3e8d2d0 
>   libs/main/rdf/KoRdfSemanticTreeWidgetItem.cpp de2c34c 
>   libs/main/rdf/RdfSemanticTreeWidgetAction.h 438fb43 
>   libs/main/rdf/RdfSemanticTreeWidgetAction.cpp c55b477 
>   libs/main/rdf/RdfSemanticTreeWidgetSelectAction.cpp 4e527ff 
>   plugins/textshape/TextTool.cpp 8eb7483 
>   plugins/textshape/commands/TextPasteCommand.cpp 514fe70 
>   tools/koabstraction/KoAbstractApplicationController.cpp 89440a0 
>   tools/mobile/ApplicationController.cpp 008233c 
>   words/part/KWView.cpp 0232eae 
>   words/part/dialogs/KWInsertInlineNoteDialog.cpp abe18a9 
>   words/part/dockers/KWRdfDocker.cpp b8ebd83 
>   words/part/dockers/KWRdfDockerTree.h d9a2e3c 
>   words/part/dockers/KWRdfDockerTree.cpp 619135a 
> 
> Diff: http://git.reviewboard.kde.org/r/102168/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110801/adcec8ca/attachment-0001.html>


More information about the calligra-devel mailing list