Review Request: Stage: save zoom factor for normal view and slides sorter between sesions

[Paul Mendez]

> On April 22, 2011, 5:21 a.m., Thorsten Zachmann wrote:
> > kpresenter/part/KPrViewModeSlidesSorter.cpp, line 584
> > <http://git.reviewboard.kde.org/r/101129/diff/3/?file=14792#file14792line584>
> >
> >     As m_zoom is a member variable the int needs to be removed otherwise you are shadowing the variable.

Here the intention was to provide a default value for the firs run, so shadowing the variable was intentional, maybe I could change the name of the variable to notice that it's a variable just fot this method.


> On April 22, 2011, 5:21 a.m., Thorsten Zachmann wrote:
> > kpresenter/part/KPrView.cpp, line 459
> > <http://git.reviewboard.kde.org/r/101129/diff/3/?file=14790#file14790line459>
> >
> >     Center the page when zooming is wrong. The zoom should always keep the current center when zooming. (This seems to be broken at the moment)

Ok, so I can expect that it's going to be fixed in the future?. 
As zooming is a function used in all calligra suite I didn't want to modify the zooming mechanism directly. Putting centerPage() in a specific Stage View, let me to correct the wrong behaviour, and avoid broke other parts of calligra.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101129/#review2815
-----------------------------------------------------------


On April 20, 2011, 2:52 a.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101129/
> -----------------------------------------------------------
> 
> (Updated April 20, 2011, 2:52 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add save of zoom factor and mode for normal view and slides sorter. Also eliminate page and width options of zooming in Slides Sorter (these options doesn't make much sense in that view).
> Finally I eliminate the white space around the slide because it make the slide lost focus when zooming and when I restore the previous zoom value (the zoom function center the white space too), in addition the white space make too big the default size of shapes when inserted.
> (I ask in calligra channel, and the white space was added to have an area for insert things, maybe it could be added in a better way).
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrView.h 80b67520be60500ecf11df0827f1d4ee8eeab4e7 
>   kpresenter/part/KPrView.cpp aef56d9fcb919a314f0095629bea1927916f8059 
>   kpresenter/part/KPrViewModeSlidesSorter.h ec5f6691072115eb7818f1eb224f6a03fe9bf13c 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp b4fee3c755aebf65e9bff0cef5516776533ec4a6 
>   libs/kopageapp/KoPAView.h 5585364c4bf0503e312a302b91f762653aaf98bb 
>   libs/kopageapp/KoPAView.cpp c53edecb309098949f66e9d50238bc60f26f9bee 
> 
> Diff: http://git.reviewboard.kde.org/r/101129/diff
> 
> 
> Testing
> -------
> 
> build and run
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110423/dd6010d5/attachment.htm>