Review Request: Fix to insert document information in InfoVariable Plugin

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101146/#review2697
-----------------------------------------------------------



plugins/variables/InfoVariable.cpp
<http://git.reviewboard.kde.org/r/101146/#comment2382>

    This change is not needed if the values are passed as suggested in the factory.



plugins/variables/InfoVariable.cpp
<http://git.reviewboard.kde.org/r/101146/#comment2381>

    This change is not needed. 



plugins/variables/InfoVariable.cpp
<http://git.reviewboard.kde.org/r/101146/#comment2383>

    I think it is much clearer to use the code as it was before as the default value will be 0 if it is not found.



plugins/variables/InfoVariableFactory.cpp
<http://git.reviewboard.kde.org/r/101146/#comment2380>

    Please use the value of the enum here: In this case use KoInlineObject::AuthorName instead of 1.
    Please add a blank after ,
    This is also true for the other variables.


- Thorsten


On April 17, 2011, 10:23 a.m., Sri Ram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101146/
> -----------------------------------------------------------
> 
> (Updated April 17, 2011, 10:23 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Fixing InfoVariable plugin to insert essential document information (Author Name, Document Title and Document Subject) into documents.
> 
> 
> Diffs
> -----
> 
>   plugins/variables/InfoVariable.cpp 9f3f2eb 
>   plugins/variables/InfoVariableFactory.cpp 6b39af1 
> 
> Diff: http://git.reviewboard.kde.org/r/101146/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110417/fb60577c/attachment.htm>