Review Request: Stage: save zoom factor for normal view and slides sorter between sesions

Paul Mendez paulestebanms at gmail.com
Sat Apr 16 21:45:24 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101129/
-----------------------------------------------------------

(Updated April 16, 2011, 8:45 p.m.)


Review request for Calligra.


Changes
-------

I restore the white space and add centering when zooming, but I still need to find a way to center when loading.
Also I move zoom saving and loading to normal view, and other changes to fix other comments.


Summary
-------

Add save of zoom factor and mode for normal view and slides sorter. Also eliminate page and width options of zooming in Slides Sorter (these options doesn't make much sense in that view).
Finally I eliminate the white space around the slide because it make the slide lost focus when zooming and when I restore the previous zoom value (the zoom function center the white space too), in addition the white space make too big the default size of shapes when inserted.
(I ask in calligra channel, and the white space was added to have an area for insert things, maybe it could be added in a better way).


Diffs (updated)
-----

  kpresenter/part/KPrView.h 80b67520be60500ecf11df0827f1d4ee8eeab4e7 
  kpresenter/part/KPrView.cpp aef56d9fcb919a314f0095629bea1927916f8059 
  kpresenter/part/KPrViewModeSlidesSorter.h ec5f6691072115eb7818f1eb224f6a03fe9bf13c 
  kpresenter/part/KPrViewModeSlidesSorter.cpp b4fee3c755aebf65e9bff0cef5516776533ec4a6 
  libs/kopageapp/KoPAView.cpp c53edecb309098949f66e9d50238bc60f26f9bee 

Diff: http://git.reviewboard.kde.org/r/101129/diff


Testing
-------

build and run


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110416/2435eb05/attachment.htm>


More information about the calligra-devel mailing list