Review Request: Lists bug fixes and enhancement

Gopalakrishna Bhat gopalakbhat at gmail.com
Sun Apr 10 05:09:03 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100918/
-----------------------------------------------------------

(Updated April 10, 2011, 4:09 a.m.)


Review request for Calligra.


Changes
-------

Changes:
Incorporate the review comments.
Fix the FontSize must be greater than zero messsage that was coming in previous versions of this patch.
Update the bugs fixed with 260099


Summary
-------

Fixes the following problems in list rendering
1)The type of list item was not shown in the paragraph docker(SimpleParagraphWidget).
2)Takes into account the font-size percent while loading and saving lists.
3) Prefixes and suffixes are now displayed for bulleted lists.


This addresses bugs 260099 and 264143.
    http://bugs.kde.org/show_bug.cgi?id=260099
    http://bugs.kde.org/show_bug.cgi?id=264143


Diffs (updated)
-----

  filters/words/oowriter/oowriterimport.cc 2bd55ee 
  libs/kotext/styles/KoCharacterStyle.h 0c9cc9c 
  libs/kotext/styles/KoCharacterStyle.cpp 072cb2f 
  libs/kotext/styles/KoListLevelProperties.h 14814fe 
  libs/kotext/styles/KoListLevelProperties.cpp 62a5175 
  libs/kotext/styles/KoListStyle.h bee4eaf 
  libs/kotext/styles/KoListStyle.cpp 52d7c2f 
  libs/odf/KoStyleStack.h 2f4d2cf 
  libs/odf/KoStyleStack.cpp 491f14e 
  plugins/textshape/ListItemsHelper.cpp aa61481 
  plugins/textshape/TextShapeLayout.cpp b980379 
  plugins/textshape/commands/ChangeListCommand.cpp 23eeee0 
  plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 14c5fd7 
  plugins/textshape/dialogs/SimpleParagraphWidget.cpp a991665 
  plugins/textshape/tests/TestChangeListCommand.cpp 4da46d1 
  plugins/textshape/tests/TestLists.cpp 316f5f6 
  tools/mobile/ApplicationController.cpp 83ebe6e 
  words/part/KWDLoader.cpp e99435a 
  words/part/KWDocument.cpp 21ce4ba 
  words/plugins/scripting/Style.h a72c0d2 

Diff: http://git.reviewboard.kde.org/r/100918/diff


Testing
-------


Thanks,

Gopalakrishna

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110410/a01f1bca/attachment.htm>


More information about the calligra-devel mailing list