Review Request: I added some icons to the Tool Options Widget

Samuel Buttigieg sambut1987 at gmail.com
Fri Apr 8 19:58:20 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101064/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

need feedback on "createOptionWidgets()" mod for calligra tables, thx


Diffs
-----

  tables/ui/CellToolBase.h 1e85233 
  tables/ui/CellToolBase.cpp 3557fb1 
  tables/ui/SimpleBorderWidget.h PRE-CREATION 
  tables/ui/SimpleBorderWidget.cpp PRE-CREATION 
  tables/ui/SimpleFillWidget.h PRE-CREATION 
  tables/ui/SimpleFillWidget.cpp PRE-CREATION 
  tables/ui/SimpleMergeWidget.h PRE-CREATION 
  tables/ui/SimpleMergeWidget.cpp PRE-CREATION 
  tables/ui/SimpleNumFormatWidget.h PRE-CREATION 
  tables/ui/SimpleNumFormatWidget.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101064/diff


Testing
-------

the icons work fine, perhaps the fill icon needs a bit more work


Screenshots
-----------

the modified view
  http://git.reviewboard.kde.org/r/101064/s/117/


Thanks,

Samuel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110408/98d10372/attachment.htm>


More information about the calligra-devel mailing list