Review Request: Fix for Reducing the various hardcoded zoomlevel based on usability feedback from Anna
Casper Boemann
cbr at boemann.dk
Mon Apr 4 07:31:12 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101022/#review2372
-----------------------------------------------------------
I think the 100% should staty. That is what Anna-lisa said too
Also I'm not either for or against it, but the options in the widget in the bottom corner is removed too with this patch
- Casper
On April 3, 2011, 9:12 p.m., Suresh Chande wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101022/
> -----------------------------------------------------------
>
> (Updated April 3, 2011, 9:12 p.m.)
>
>
> Review request for Calligra, Marijn Kruisselbrink, Thorsten Zachmann, and Casper Boemann.
>
>
> Summary
> -------
>
> Ok Here comes my first fix..
>
> Here is my fix I made to the zoom levels based on discussion and agreement at the Calligra sprint that we do not want to have 33, 57 and 127 etc % zoom levels . This fix removes the different zoom levels but leaves fit to width and fit to page.
>
> See testing done, Any suggestion how this should be it be fixed for Tables ?
>
>
> Diffs
> -----
>
> libs/widgets/KoZoomAction.cpp 488652c
>
> Diff: http://git.reviewboard.kde.org/r/101022/diff
>
>
> Testing
> -------
>
> This was tested in the Words and Stage application and it functions according to expected outcome. I tested the Tables it seems as Tables does not have Fit to Width or Fit to Page the menu is currently empty.
>
>
> Thanks,
>
> Suresh
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110404/b3ed4f88/attachment.htm>
More information about the calligra-devel
mailing list