First Patch for Calligra

Boudewijn Rempt boud at valdyas.org
Tue Nov 23 09:32:21 GMT 2010


On Tuesday 23 November 2010, Cyrille Berger Skott wrote:
> On Tuesday 23 November 2010, Yue Liu wrote:
> > Created from the git repo. The patch is about the blur effect to the
> > shape shadow:)
> Nice. Only one comment, multi-license in one file is not really good, so you 
> can either put the blurShadow in a seperate private file (like 
> KoShapeShadow_p.h) or as the BSD license is GPL-compatible and instead either 
> remove the comment, or replace it by "// You can find a BSD version of that 
> function here: [url]".

Also -- unless you wrote the blur yourself, you have to make clear where that code came from. I also think it's time to start integrating our non-krita filters better, since there is also a blur effect in karbon.

-- 
Boudewijn Rempt | http://www.valdyas.org
Ceterum censeo lapsum particulorum probae delendum esse



More information about the calligra-devel mailing list