Review Request: Force no backgound on connection shapes

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100259/#review651
-----------------------------------------------------------

Ship it!


Looks good.

- Thorsten


On 2010-12-28 19:13:58, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100259/
> -----------------------------------------------------------
> 
> (Updated 2010-12-28 19:13:58)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This patch removes the background from connection shapes when a background is set. I think it makes no sense to allow the connection shape to have a background and it actually fixes the bug mentioned above.
> 
> 
> This addresses bug 251484.
>     http://bugs.kde.org/show_bug.cgi?id=251484
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoConnectionShape.cpp 3a416c2 
> 
> Diff: http://git.reviewboard.kde.org/r/100259/diff
> 
> 
> Testing
> -------
> 
> Tested with the test document which is attached to bug 251484.
> 
> 
> Thanks,
> 
> Jan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20101229/252fb41e/attachment.htm>