Review Request: Few fixes to pathshape/enhancedpath

[Jan Hambrecht]

> On 2010-12-27 23:16:49, Jan Hambrecht wrote:
> > plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp, line 103
> > <http://git.reviewboard.kde.org/r/100254/diff/1/?file=5715#file5715line103>
> >
> >     The ODF specification does really lack in that section. The sweeping angle is to be determined from start to end angle. But the direction of the sweep is not specified at all. So you never know which side of the ellipse should be drawn (i.e. clockwise or counter-clockwise). The old code always forced the sweep to be counter-clockwise.
> >     I am not sure which is better, do you?
> 
> Lassi Taneli Nieminen wrote:
>     My thinking here was that there's no need to specify the direction in the spec as it can be always calculated based on the end angle.
>     Eg. if start angle is 180: case1 end angle 90, 90-180 = -90 <-counter clockwise, case2: end angle 450: 450-180 = 270 -> clockwise

The problem with that is that you never know the intention of the application which wrote the start and end angle.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100254/#review641
-----------------------------------------------------------


On 2010-12-27 21:17:13, Lassi Taneli Nieminen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100254/
> -----------------------------------------------------------
> 
> (Updated 2010-12-27 21:17:13)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Few fixes to pathshape/enhancedpath
> 1. In T the parameters are w/h, to get radiuses they should be divided by two
> 2. Allow T to have sweep angle to both directions as odf spec does not limit it to one direction.
> 3. The move after T had wrong y axis direction
> 4. When loading odf, load viewBox before evaluating path. This because path may have references to w,h,l,r,t,b and those are defined
> from viewBox.
> 
> Feel free to ignore changes to rest of the files.
> 
> 
> Diffs
> -----
> 
>   filters/kpresenter/pptx/PptxXmlSlideReader.cpp 206ccdf 
>   filters/libmsooxml/ComplexShapeHandler.h d1c78e3 
>   filters/libmsooxml/ComplexShapeHandler.cpp 622af85 
>   filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h eb03cf9 
>   filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h d5732fc 
>   filters/libmsooxml/MsooXmlCommonReaderImpl.h 138e797 
>   filters/libmsooxml/MsooXmlCommonReaderMethods.h e99c747 
>   filters/libmsooxml/generated/generatedShapes.h f8b3b2a 
>   filters/libmsooxml/generated/generator.cpp 72e8c0a 
>   filters/words/docx/DocxXmlDocumentReader.h d7fb2f5 
>   filters/words/docx/DocxXmlDocumentReader.cpp 231a3e7 
>   plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp 7fcd453 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 2c26294 
> 
> Diff: http://git.reviewboard.kde.org/r/100254/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lassi Taneli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20101228/ae1276c3/attachment.htm>