A problem with KoToolManager and a bug 258422

[Dmitry Kazakov]

Hi!

I have the following problem: when you make a layer invisible, the
KoToolManager deactivates the tool associated with the canvas [1].
And the worst thing, it doesn't call the deactivate() method of the tool it
deactivates. In Krita it leads that the cursor is not restored in case the
user uses the "Outline cursor".

Actually, i don't know how to fix this problem.

The most obvious solution is to call the deactivate method from somewhere
inside the tool manager. But, i guess, this is not a good idea, because in
this very state (invisibility of the layer) the tool is "half" activated: it
is activated in the tool manager and is deactivated in the tool proxy.
Actually, i feel this is quite a strange state =( In the best case, in
should be activated either everywhere or nowhere.

What do you think about this problem?


[1] - KoToolManager.cpp:622 --
http://gitweb.kde.org/calligra.git/blob/HEAD:/libs/flake/KoToolManager.cpp#l622
-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20101209/0305d97e/attachment.htm>