Review Request 121450: KF5/Qt5 Port

[Eshton Robateau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121450/
-----------------------------------------------------------

Review request for Bangarang.


Repository: bangarang


Description
-------

The basic listengine architecture and necessary classes have been ported. The are a few stubs for local storage and metadata handling. Dependencies updated for phonon, at present KF5 is incompatible with phonon4, so we have to build explicitly against phonon4qt5. 

http://quickgit.kde.org/?p=clones%2Fbangarang%2Ferobateau%2Fmybangarang.git&a=commit&h=75cffc44f3253d5ebdac15654e53b271bfe3f413


Diffs
-----

  CMakeLists.txt 6400e43 
  cmake/FindLibraryWithDebug.cmake PRE-CREATION 
  cmake/FindTaglib.cmake PRE-CREATION 
  src/CMakeLists.txt bbe2b31 
  src/app/main.cpp 92bfe4d 
  src/platform/devicemanager.h PRE-CREATION 
  src/platform/devicemanager.cpp PRE-CREATION 
  src/platform/downloader.h PRE-CREATION 
  src/platform/downloader.cpp PRE-CREATION 
  src/platform/listengines/cachelistengine.h PRE-CREATION 
  src/platform/listengines/cachelistengine.cpp PRE-CREATION 
  src/platform/listengines/filelistengine.h PRE-CREATION 
  src/platform/listengines/filelistengine.cpp PRE-CREATION 
  src/platform/listengines/listengine.h PRE-CREATION 
  src/platform/listengines/listengine.cpp PRE-CREATION 
  src/platform/listengines/listenginefactory.h PRE-CREATION 
  src/platform/listengines/listenginefactory.cpp PRE-CREATION 
  src/platform/listengines/medialistsengine.h PRE-CREATION 
  src/platform/listengines/medialistsengine.cpp PRE-CREATION 
  src/platform/listengines/savedlistsengine.h PRE-CREATION 
  src/platform/listengines/savedlistsengine.cpp PRE-CREATION 
  src/platform/mediaitemmodel.h PRE-CREATION 
  src/platform/mediaitemmodel.cpp PRE-CREATION 
  src/platform/medialistcache.h PRE-CREATION 
  src/platform/medialistcache.cpp PRE-CREATION 
  src/platform/utilities/artwork.h PRE-CREATION 
  src/platform/utilities/artwork.cpp PRE-CREATION 
  src/platform/utilities/filetags.h PRE-CREATION 
  src/platform/utilities/filetags.cpp PRE-CREATION 
  src/platform/utilities/general.h PRE-CREATION 
  src/platform/utilities/general.cpp PRE-CREATION 
  src/platform/utilities/mediaitems.h PRE-CREATION 
  src/platform/utilities/mediaitems.cpp PRE-CREATION 
  src/platform/utilities/sha256.h PRE-CREATION 
  src/platform/utilities/sha256.cpp PRE-CREATION 
  src/platform/utilities/thread.h PRE-CREATION 
  src/platform/utilities/thread.cpp PRE-CREATION 
  src/platform/utilities/typechecks.h PRE-CREATION 
  src/platform/utilities/typechecks.cpp PRE-CREATION 
  src/platform/utilities/utilities.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121450/diff/


Testing
-------

No unit tests in place, no serious warnings (insignificant Wunused-parameter reminders) in builds. 


Thanks,

Eshton Robateau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/bangarang/attachments/20141211/0dadeecb/attachment.html>