[Bug 300557] When a collection is updated, Amarok expands collapsed entries in the Collection Browser

[Robert Marshall]

On Wed, May 21 2014, Matěj Laitl <matej at laitl.cz> wrote:

> On 20. 5. 2014 Robert Marshall wrote:
>> I've recently updated amarok via git and got Matěj's fix - which does
>> look good. Unfortunately there's I guess a side effect (at least I
>> assume the change is responsible for this) that if you - in the play
>> list - click 'Show in Media Sources' before that used to open that album
>> fully in sources showing all the tracks, now - for me - it opens down to
>> one level (I have Album->TrackArtist sorting) and you have to move the
>> mouse over to see the tracks - so the menu option doesn't actually show
>> the track in media sources - you have to fiddle slightly to get it
>> shown!
>> 
>> Is this a necessary side effect of the fix (was the previous behaviour
>> regarded as part of the 300557 bug) or do you want me to file a bug
>> report?
>
> I think that yes, this is a side-effect. My fix revealed a bug in 
> CollectionTreeView::slotCheckAutoExpand() - it does not count with the fact 
> that CollectionTreeItemModel is asynchronous. Previously this bug was hidden 
> because slotCheckAutoExpand() got (mistakenly) called multiple times.
>
> The solution would be to make slotCheckAutoExpand() aware of asyncronicity of 
> the model - perhaps by introducing a single-shot RAII class to expand what is 
> necessary and then auto-delete itself.
>
>> I didn't want to comment on the bug
>> https://bugs.kde.org/show_bug.cgi?id=300557 as that would have re-opened
>> it...
>
> A mere commenting does not reopen it, but yes, opening a new bug is more 
> correct.
>

Filed as bug

https://bugs.kde.org/show_bug.cgi?id=335217

Robert
-- 
La grenouille songe..dans son château d'eau