[Amarok] Check to make sure mysql server hasn't gone away b

Ian Monroe ian.monroe at gmail.com
Mon Oct 5 01:19:20 UTC 2009


On Sun, Oct 4, 2009 at 6:01 PM, Jeff Mitchell <mitchell at kde.org> wrote:
> Peter C. Ndikuwera wrote:
>> This patch breaks my amarok. I'm using the MySQL server
>>
>> See attached crash dump.
>>
>> When I comment out the block with mysql_ping in it, I run fine.
>
> Yes, I'm aware of the problem.
>
> Just not the cause.

MySqlCollection::query has this code:
    if( !m_db )
    {
        error() << "Tried to perform query on uninitialized MySQL";
        return values;
    }

Which is missing in the override. So I'm guessing a null m_db is possible.

It also has a mutex.

Ian



More information about the Amarok mailing list