Bug fix : crash with mp4 files

Seb Ruiz ruiz at kde.org
Tue Mar 17 22:55:26 UTC 2009


2009/3/18 Valentin Rouet <valdu85 at gmail.com>:
> Here is a patched version of src/meta/File_p.h :
> Amarok was crashing when it tried to read tags in mp4 files that had an
> empty "composer" or "album" tag.
>
> I added 2 tests :
> if ( !mp4tag->itemListMap()["\xA9wrt"].toStringList().isEmpty() )
>                 m_data.composer = strip(
> mp4tag->itemListMap()["\xA9wrt"].toStringList().front() );
> if ( mp4tag->itemListMap()["disk"].toIntPair().first != NULL)
>                 disc = QString::number(
> mp4tag->itemListMap()["disk"].toIntPair().first );

Hi Valentin,
Please attach your modifications as a patch, not the entire file. We
can't merge these changes in or see the exact differences. This is
easy to do by modifying an svn checkout and running the command: `svn
diff`

>
> Thanks for your reviews,
> Valentin
>
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>
>



-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/



More information about the Amarok mailing list