little cleanup/patch regarding iPod handling in cmake

[Alejandro Wainzinger]

Committed.  Thanks for the patch.

2009/6/23 Maciej Mrozowski <reavertm at wp.pl>:
> Hi
>
> Recent commits introduced a little mess with ipod handling in CMake.
> Proposed patch:
> - removes redundant Ipod and Gdk autodetection from
> collection/ipodcollection/CMakeLists.txt (they are in toplevel CMakeLists.txt
> alrady) - this fixes automagic dependency
> - cleaned up toplevel CMakeLists.txt: fixed inconsistencies WITH_IPOD vs
> WITH_Ipod, , added WITH_IPOD cmake option that determines further
> find_package(Ipod)
> -  changed "required" flag from FALSE to TRUE in macro_log_feature of
> liblastfm - currently this change will do nothing, just for consistency
>
> There's also encouragement to drop find_package(xxx REQUIRED) in favour of
> find_package(xxx) with macro_log_feature (..... ...... ...   TRUE ....), so
> that cmake dependency detection won't be terminated on first unsatisfied
> dependency, but it will carry on with detection, and display summary at the
> end (bailing out if any of required deps are unsatisfied) - this way one can
> see a list of all unmet deps in one shot not being forced to discover them one
> bye one.
>
> --
> regards
> MM
>
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>
>