patch for src/playlist/view...

Nikolaj Hald Nielsen nhnfreespirit at gmail.com
Wed Jan 14 17:39:36 UTC 2009


On Tue, Jan 13, 2009 at 4:21 PM, Thomas Lübking <thomas.luebking at web.de> wrote:
> I'll try to not be offended by the "normal humans" statement... ;-)

Ha. "Normal humans" as opposed to hackers! :-D

> Ok, we could easily alter parsing like:
> - support fifo ('last occurence rules') "width" and "max-width" (as well as
> no width statement at all)

Hmm... I would really rather not have any parsing of the xml file
depend on the relative position of the attributes.

> - additionally handle the value suffix, i.e. differ "<n>em" from "<n>%"
> (currently the scale isn't clear anyway) with no suffix indicating: (?)
> (i'd vote for em, pt and px make few sense in arranging
> text-only-item-witdths anyway and a factor feels natural than percentage)

You completely lost me on that one, sorry.... I really thing we should
stick to just percentage width or auto width as this is not intended
to be a text editor. Later on we can always reevaluate.

> - we still could keep encoding this info into the single double value or add
> two more bools ("widthIsPercent", "widthIsFix/Max" - wasting large areas of
> the double) =D

You seem to have some excellent ideas for how to make the playlist
super flexible. I have come to think though that we should be very
careful not to pile too much complexity on top right now as we also
need to get the config widget done before 2.1.0. I am actually quite
happy with the way it works now. So I think I would prefer if we could
just fix the issues that are there now and then not make the layout
system any more complex until after 2.1.0. At that time adding to the
layout and exposing the functionality to the editor will be possible
at the same time as there will actually be an editor.

The original mockup of how this editor should work is here:
http://amarok.kde.org/blog/archives/810-The-Old-style-Playlist-Is-Dead,-Long-Live-The-Old-style-Playlist.html

- Nikolaj



More information about the Amarok mailing list