Patch for Bug #177403: "Amarok does not remove leading blanks in podcast"
Seb Ruiz
ruiz at kde.org
Sun Jan 11 22:01:30 UTC 2009
2009/1/12 Nicholas Sinlock <isolatedincident at gmail.com>:
> Nicholas Sinlock wrote:
>> Mark Kretschmann wrote:
>>> On Sun, Jan 11, 2009 at 5:12 PM, Nicholas Sinlock
>>> <isolatedincident at gmail.com> wrote:
>>>
>>>> In addition to stripping the leading blanks from podcast titles, I
>>>> also
>>>> implemented a function to remove any part of the channel title
>>>> that is also found at the start of the episode title, as in the case of
>>>> Scientific American's 60 Second Science podcast, found
>>>> at http://www.sciam.com/podcast/sciam_podcast_r_d.xml. I
>>>> implemented that
>>>> rather than using the decapitateString as the latter function
>>>> had the side effect of sometimes removing several characters from a
>>>> word,
>>>> effectively truncating a proper word into a non-proper word.
>>>>
>>>> The .diff is attached.
>>>>
>>>
>>> Thank you very much for the patch, Nicholas, but could you please
>>> adhere to our coding style? It's explained in detail here:
>>>
>>> http://kollide.net:8060/browse/~raw,r=20999/Amarok/HACKING/intro_and_style.txt
>>>
>>>
>>>
>>> The problem is that we have to reformat your patch before committing,
>>> and this is a lot of work if done manually. We do have an
>>> auto-formatter tool, but it's hard to run this over the patch alone,
>>> without changing the whole file.
>>>
>>>
>> I apologize, I will do that from now on. I'm still a bit new to the
>> KDE project.
>>
> I do not have an svn account. Will you be committing the patch, or do I
> need to reformat the patch first?
> Thanks for your help.
Please reformat the patch and attach it here as a diff, rather than
pasting it inline. This is best for us. What would be best for
everyone, however, would be if you just got yourself an SVN account
and commit yourself :)
http://techbase.kde.org/Contribute/Get_a_SVN_Account
--
Seb Ruiz
http://www.sebruiz.net/
http://amarok.kde.org/
More information about the Amarok
mailing list