Bug 189898 fix

[Ignacio Serantes]

Hi!

This is my first message in this list so hello to all and thank's to all Amarok 
developers for this program.

I'm learning this weekend how to compile Amarok and I do some test with some 
bugs that anoing me a lot: 188446, 202027 and 189898.

Bug 188446 was fixed, thanks Mark for doing the job and I'm think that bug 
202027 is a Phonon Xine engine bug but I waiting for an expert confirmation.

But the core of this message was a correction for bug 
https://bugs.kde.org/show_bug.cgi?id=189898, can't play files containing space 
in their name...

If you read comments I write a patch to solve the problem. The bug was located 
in EngineController:playUrl (EngineController.cpp) in line 388 because Amarok 
is doing the same treatment for all Uris and GStreamer Engine can't locate the 
file if there is spaces or not english characters in the path.

My suggestion is change the line

<*--*--*--*--*--*--*--*--*--*--*--*--*--*>

m_media->setCurrentSource( url );

<*--*--*--*--*--*--*--*--*--*--*--*--*--*>


for 

<*--*--*--*--*--*--*--*--*--*--*--*--*--*>

if ( url.toLocalFile() == "" )
{
	m_media->setCurrentSource( url );
} 
else
{
	m_media->setCurrentSource( url.toLocalFile() );
} 

<*--*--*--*--*--*--*--*--*--*--*--*--*--*>

With this path both Xine and GStrimer engines play both remote streams and 
local files without problems. A similar thing was coded for "audiocd:/".

I'm neither a C++ or KDE programmer so probably my path could be refined for 
somebody with more skills.


-- 

Un saúdo

Ignacio Serantes (kde at aynoa.net)
Nos - Oleiros - A Coruña
España
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok/attachments/20090802/1ff13d65/attachment.html>