Fwd: extragear/multimedia/amarok/src

[Dan Meltzer]

Well, Then consider this a formal request for people to test and see
if the last track in a playlist is getting its statistics updated
after this commit.


---------- Forwarded message ----------
From: Mark Kretschmann <kretschmann at kde.org>
Date: Mon, Dec 15, 2008 at 12:35 PM
Subject: Re: extragear/multimedia/amarok/src
To: kde-commits at kde.org


On Mon, Dec 15, 2008 at 5:10 PM, Dan Meltzer
<parallelgrapefruit at gmail.com> wrote:
> On Mon, Dec 15, 2008 at 4:06 AM, Mark Kretschmann <kretschmann at kde.org> wrote:
>> SVN commit 897071 by markey:
>>
>> When reaching the end of the playlist, make Amarok actually show that
>> playback has stopped. Until now it happily continued to display "Playing
>> Foo by Bar.."
>>
>> As usual with all changes to EngineController, this patch could have
>> subtle side effects, so please keep testing extensively.
>
> Without poking my head into EngineController.cpp ... Won't this change
> prevent the last tracks statistics from updating? I'm not sure how
> this change fixes the issue....

This remains to be tested. The problem was that
"m_currentTrack->finishedPlaying( 1.0 )" initiated a long chain of
things it shouldn't have been doing.

In this case, we should fix Meta::SqlTrack (or WhateverTrack)
::finishedPlaying to not trigger things that it shouldn't trigger,
rather than not callling it (and therefore not triggering things that
it should trigger)

--
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org