[PATCH] Enable playing of last.fm's tag stations

[Nikolaj Hald Nielsen]

Hi Trevor

I just tested your patch, and it works great. There are a few minor
style nitpicks, but nothing major.

My main concern is that I really don't like the interface. In my
opinion it is  counter intuitive that the "go" button is also the
selector. Also, there is no way to tell what pressing "go" will
actually do without consulting the drop down list ( how do you know
what the default is when you just started Amarok? )

A better approach, I think, would be to have the drop-down box as a
separate element so you have "dropdown - text-edit - go-button". They
you would always be able to see what the current "mode" is.

We do have plans to rework the Last.fm service somewhat, and it would
be great if you would like to help with this. Overall your patch is a
great start ( and something we have thought about doing for a long
time ) but the interface for it needs to be a bit clearer.

It could also be interesting to ad other types, such as group radio
stations and so on! :-)

I hope you take this as constructive criticism and I hope to see an
updated patch from you soon! If you want to discuss this some more,
feel free to drop by channel #amarok on irc.freenode.net, you can ping
me there as "nhnFreespirit"

- Nikolaj

On Sun, Dec 7, 2008 at 10:58 PM, Trever Fischer <wm161 at wm161.net> wrote:
> I noticed that for a while, Amarok didn't have the ability to play tag
> stations on last.fm. It only had artists, so I wrote this rather simple patch
> to add it. I'm not familiar with the coding style (particularly the header
> includes in my patch) and I'm also not sure if changing the play button to a
> qtoolbutton would upset anyone. I wanted to get some feedback before I commit
> or anything.
>
> I've seen those 'cut-in-half' looking buttons (eg in GHNS) with two separate
> clickable areas (a main 'button' and a small arrow sub-button) but I couldn't
> find where they live in KDElibs.
>
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>
>