[Patch] Dynamic Playlists: Change Text on "On"-Togglebutton to "Off" if deactivated

[Daniel Jones]

Hi Andreas,
We discussed this a bit, and we decided it would be better if the text
didn't change. It's a bit subjective, but changing the text may be
confusing to some (i.e. does "Off" mean it's currently off, or does it
mean pressing the button will turn it off?).

It's really cool that you want to contribute to amarok though. If you
stop by the #amarok.dev irc channel sometime, someone will certainly
have a good idea of something you could work on.

~Daniel

On Sun, Aug 24, 2008 at 12:26 PM, Andreas Mützel
<andreas.muetzel at gmx.net> wrote:
> Hi,
>
> yesterday I talked one of the amarok-developers at FrOScon (I can't remember
> the name, sorry...), because I have a little spare time and want to
> contribute to amarok.
> One of two problems that seemed possible to fix for a beginner was the text
> that is shown on the button that enables and disables dynamic playlists.
> Currently it only shows "On", whether or not it is toggled.
> The attached patch changes this, so the text is now "On", if dynamic playlists
> are activated and "Off", if they are deactivated.
> In my opinion, this makes it a little bit easier to realize whether the button
> is activated or not. Feel free to disagree ;-)
> If I understood the dev at FrOScon correctly, you are currently in string- and
> feature-freeze, aren't you? If so: There is already an "Off"-string in
> ActionClasses.cpp, would the string-freeze nonetheless prevent my patch from
> being included in the current version of amarok?
> (see ActionClasses.cpp:339:    setItems( QStringList() << i18nc( "State, as in
> disabled", "Off" ) )
> Attached is the output of "svn diff" in the "src"-directory of revision
> 851845.
>
> Greetings
> Andreas
>
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>
>