[PATCH] proposed fix for the "amarok freezes when the install mp3 support dialog appears" bug

[Sascha Sommer]

Hi,

On Friday 31 August 2007 14:33, Mark Kretschmann wrote:
> On 8/29/07, Sascha Sommer <ssommer at suse.de> wrote:
> > the attached patch fixes
> >
> > https://bugs.kde.org/show_bug.cgi?id=147126
> > https://bugzilla.novell.com/show_bug.cgi?id=304202
> >
> > "After loading an mp3 in amarok, I get a popup that asks if I want to
> > install mp3 support.  This is an excellent idea and feature -- but it
> > doesn't work. Amarok freezes right off, and is un-usable. I then have to
> > kill it."
> >
> > The problem seems to be that EngineController::canDecode runs in a
> > seperate thread than the gui thread. Opening up a Kmessagebox there will
> > prevent amarok from handling all gui events and everything will freeze. I
> > therefore put the dialog into an extra function that will later get
> > called from the statusBar.
> >
> > The canDecode then only has to send an event to the statusBar in order to
> > display the dialog.
>
> Sascha, thank you very much for catching this. I've committed your
> patch to SVN, and I will encourage the packagers to backport the patch
> for 1.4.7. I think it's a really important fix.

Thanks.

Regards

Sascha