[PATCH] Solution for Bug 143513 (Playlist items stay greyed out even if songs are available)

mail@martindroessler.de mail at martindroessler.de
Mon Jun 11 07:27:52 UTC 2007


> > Okay, I can agree with this.  There doesn't seem to be a reason to treat
> > disabled playlist items specially here.  Any other devs know if there's a
> > reason that filestatusdisabled is checked there (since if it's not disabled
> > it does a stat on the file anyways)?  And if there's no reason, is there a
> > reason that value is even stored?
> >
> > Thanks,
> > Jeff
> 
> Well dynamic playlists also disable items. The playlist might be put
> into some sort of weird state if Amarok is reopened, a dynamic
> playlist loaded and items that were disabled no longer are.

I thought that the check:
if( (*it).dynamicdisabled )
                 item->setDynamicEnabled( false );

handles this case. Because the mentioned variable m_enabled is only true
if filestatusenabled is true and dynamicenabled is true.

But maybe I'm wrong. Anyway, it would be great if you could verfiy this.


Regards,
MD






More information about the Amarok mailing list