[patch] slightly controversial refactor

[Andrew Turner]

Yeah, if you hadn't pointed out that there was a memory leak, it would
never have gotten fixed. Sorry if I sounded negative with my summary,
I was just annoyed with myself for having written a pointless email
explaining what had already been fixed. In any case, your patch has
certainly improved the readability of the code by clarifying the point
of each function and by removing the unexpected side-effect of
updating all devices from getDevice to its proper place in a separate
function.

Andrew

On 20/01/07, Jeff Mitchell <kde-dev at emailgoeshere.com> wrote:
> Erik, no problem.  I appreciate that you worked on this.
>
> --Jeff
>
> On Saturday 20 January 2007 14:30, Erik Hovland wrote:
> > On Sat, Jan 20, 2007 at 08:52:44PM +0000, Andrew Turner wrote:
> > > Wait, ignore me. The patch didn't fix the memory leak, but Jeff did,
> > > and in the same commit.
> >
> > I knew my patch needed more work.
> >
> > Thanks to Jeff for taking a look and sticking with it. I was struggling
> > with it on my end.
> >
> > E
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>