EBN - #10 patch

Andrew Ash ash211 at gmail.com
Mon Jan 8 06:55:43 UTC 2007


I'm a new contributor to Amarok and have a patch I'd like to submit.

I was looking on EBN (
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
) and picked one of the sections I thought I could handle, #10. -- ""
Do not assign QString::null to a QString. Instead use the .clear()
method. For example, "str = QString::null" becomes "str.clear()". When
returning an empty string from a method use "return QString()". ""

So I went through and figured out a little of working with svn,
patching process, etc, and now have a patch I'd like to be committed.
I'm not sure the proper procedure, so I created a bug report at
http://bugs.kde.org/show_bug.cgi?id=139757.  Let me know what's
appropriate in the future.

Not all of the changes worked correctly on compiling, so I've only
kept the ones that didn't prevent compilation.  I'm currently using
this modified Amarok and don't see any regressions or anything.  The
patch is at the bug's page, against current svn (621036)

Thanks for looking at this.



More information about the Amarok mailing list