[patch] removal of deadcode
aumueller at uni-koeln.de
Wed Nov 29 20:58:43 UTC 2006
thank you for your patches. I didn't apply this one, as it actually pointed at
an omission. So, please continue your work!
On Tue November 28 2006 18:44, Erik Hovland wrote:
> I have been using amarok happily for the last 4 months. Thank you for
> such a wonderful audio player. After having been happy with xmms for a
> number of years I just couldn't get over the lack of integration with my
> favorite desktop environment. So I gave amarok a try. The first few
> attempts did not fare so well. But once 1.4.2 came around the corner
> amarok was stable enough on mandriva 2006.0 for me to use exclusively.
> So it is time to give back. I have been doing a little audit of the code
> and have found a few bugs. This is the first one I have found (with the
> help of a static analysis tool). This patch removes some code that is
> never executed because the conditional that wraps it is for a variable
> that never changes value.
> Let me know what you think. And once again, thanks.
More information about the Amarok