extragear/multimedia/amarok/src

[Jeff Mitchell]

I can reproduce some crashes (and I have the code set the "bad" way) but they 
don't seem to have anything to do with that function.

When I add a bunch of local files from the collection:

#2  0x0804e007 in Amarok::Crash::crashHandler () at crashhandler.cpp:249
#3  <signal handler called>
#4  0xb666d615 in QListViewItem::itemPos () from /usr/qt/3/lib/libqt-mt.so.3
#5  0xb7c9efe0 in Playlist::reallyEnsureItemCentered (this=0x81ba8d0)
    at playlist.cpp:4325
#6  0xb7cb245b in Playlist::qt_invoke (this=0x81ba8d0, _id=170, _o=0xbf8198e4)
    at playlist.moc:539


When adding a Shoutcast stream:

#2  0x0804e007 in Amarok::Crash::crashHandler () at crashhandler.cpp:249
#3  <signal handler called>
#4  0xb66aa6fc in QListViewItem::insertItem ()
   from /usr/qt/3/lib/libqt-mt.so.3
#5  0xb66a97a5 in QListView::insertItem () from /usr/qt/3/lib/libqt-mt.so.3
#6  0xb66ab3f2 in QListViewItem::QListViewItem ()
   from /usr/qt/3/lib/libqt-mt.so.3
#7  0xb6ede170 in KListViewItem::KListViewItem ()
   from /usr/kde/3.5/lib/libkdeui.so.4
#8  0xb7d489a8 in PlaylistItem (this=0x8bcb0e0, listview=0x81ba968, 
    item=0x85f4428) at playlistitem.cpp:56
#9  0xb7d52583 in UrlLoader (this=0x8bcca38, urls=@0xbff5ca7c, 
    after=0x85f4428, playFirstUrl=false) at playlistloader.cpp:82

--Jeff


On Saturday 18 November 2006 10:46, Adam Pigg wrote:
> It happened a lot for me when adding shoutcast playlists (using the new
> browser) i suppose its possible i missed something when writing the browser
> but it worked ok before.
>
> Havnt tried with any local playlists/tracks yet.
>
> On Saturday 18 November 2006 16:40, Jeff Mitchell wrote:
> > Mark--
> >
> > What are the conditions under which this happens?  After the change was
> > made I put things in the playlist plenty of times without any crashing.
> > Besides, it seems like if there is crashing it's because either
> > item->url() or url() is invalid, which should be fixed (but it's hard for
> > me to tell which one since I can't replicate the crash).
> >
> > --Jeff
> >
> > On Saturday 18 November 2006 04:07, Mark Kretschmann wrote:
> > > SVN commit 605794 by markey:
> > >
> > > revert crap ;)
> > >
> > > This changeset made Amarok crash whenever you put something in the
> > > playlist.
> > >
> > >
> > >  M  +1 -1      playlist.cpp
> > >
> > >
> > > --- trunk/extragear/multimedia/amarok/src/playlist.cpp #605793:605794
> > > @@ -1931,7 +1931,7 @@
> > >          PlaylistItem* item;
> > >
> > >          for( item = firstChild();
> > > -             item && item->url().url() != url.url();
> > > +             item && item->url() != url;
> > >               item = item->nextSibling() )
> > >          {}
> >
> > _______________________________________________
> > Amarok mailing list
> > Amarok at kde.org
> > https://mail.kde.org/mailman/listinfo/amarok