extragear/multimedia/amarok/src

Jeff Mitchell kde-dev at emailgoeshere.com
Sat Nov 18 16:40:23 UTC 2006


Mark--

What are the conditions under which this happens?  After the change was made I 
put things in the playlist plenty of times without any crashing.  Besides, it 
seems like if there is crashing it's because either item->url() or url() is 
invalid, which should be fixed (but it's hard for me to tell which one since 
I can't replicate the crash).

--Jeff

On Saturday 18 November 2006 04:07, Mark Kretschmann wrote:
> SVN commit 605794 by markey:
>
> revert crap ;)
>
> This changeset made Amarok crash whenever you put something in the
> playlist.
>
>
>  M  +1 -1      playlist.cpp
>
>
> --- trunk/extragear/multimedia/amarok/src/playlist.cpp #605793:605794
> @@ -1931,7 +1931,7 @@
>          PlaylistItem* item;
>
>          for( item = firstChild();
> -             item && item->url().url() != url.url();
> +             item && item->url() != url;
>               item = item->nextSibling() )
>          {}



More information about the Amarok mailing list