[PATCH] MTP mediadevice

[Seb Ruiz]

Andy --
Patch looks great.  Once thing, have a read of our HACKING document.   
The only thing I picked up on is the style of if statements.  You  
should use
   if( this )

instead of
   if (this)

To the developers - I'm thinking we should include this patch for  
1.4.2-beta2, so that users can test it.  This is, if andy maintains  
the code. Thoughts?


Quoting Seb Ruiz <me at sebruiz.net>:

>
> Hi Andy,
> Awesome, thanks for your work - I'll have a look at the code, but I
> can't test it, since i don't have an mtp device.  Expect harsh
> criticism as I have high standards for coding.  Also, you must be
> prepared to maintain your patch if you want it committed.
>
> Timo - it seems that your offer to write a patch for mtp devices was
> just a tad too late :) We got this patch about 30 minutes after your
> email. We would still love your help, and would need testers.  I'm
> sure andy and yourself could work together to make this one kick arse
> plugin.
>
> The best arrangement would be to meet in #amarok on irc.freenode.net
> and discuss this. for the record, Andy is mopoke.
>
> Thanks to the two of you,
> Seb
>
> Quoting Andy Kelk <andy at mopoke.co.uk>:
>
>> (oops, posted this to amarok-devel @ sf... reposting here)
>>
>> Hello,
>>
>> I've been working recently on mediadevice support for MTP devices. It's
>> now at a stage where I am willing for its (limited) functionality to be
>> tested by other MTP device owners (if they're brave enough). My test
>> unit is a Creative Zen Vision:M so I'd be interested to see how it
>> performs with other MTP devices (particularly the non Creative ones).
>>
>> The attached patch-set is for an MTP mediadevice. Currently it can read
>> files from the device (and populate a list-view), send new files to the
>> device and delete existing files from the device.
>>
>> Code-wise, I've based it on the existing libnjb mediadevice as the two
>> libraries operate in fairly similar ways.
>>
>> This is my first stab at Amarok code (and my first C++ in quite some
>> years) so be gentle with me. I think I've covered the obvious points but
>> am quite happy to get (constructive) criticism.
>>
>> Functionality-wise, this is a short TODO of future enhancements that I
>> came up with:
>>
>> - Support more than just mp3/wma files (devices can, I think, tell you
>> what formats they support)
>> - Allow users to browse using the folders/files view supplied by MTP
>> - Allow users to define the filtering in the view (artist/album, album
>> only, genre/artist/album, etc)
>> - Playlist handling
>> - Create Album/Artist folders on the device when copying tracks (allow a
>> format-string specification)
>> - Copy tracks from device to the host
>> - Other device info like battery level, etc
>>
>>
>> Andy
>>
>>
>>
>
>
>
> --
> http://www.sebruiz.net/
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>



-- 
http://www.sebruiz.net/