extragear/multimedia/amarok/src
Nikolaj Hald Nielsen
nhnfreespirit at gmail.com
Wed Dec 13 21:39:18 UTC 2006
> any artistic opinions?
Well, I doubt that my oppinion is all that artistic, but I think it
looks great with the shadows, and it looks very simmilar to the small
covers shown in the context browser.
- Nikolaj
On 12/13/06, Andrew Turner <andrewturner512 at googlemail.com> wrote:
> Further to Robert Hogan's suggestion for the images needing some sort
> of softening effect, here's an image with shadows that's as identical
> to the previous one as I could make it:
> http://www.srcf.ucam.org/~ajt60/amarok/covercollection_shadow.png
>
> For reference, here's the one without shadows again:
> http://www.srcf.ucam.org/~ajt60/amarok/covercollection.png
>
> It's obvious that it takes up a bit more room, but it shouldn't end up
> being any slower, as the images with shadows added get cached. Still,
> any artistic opinions?
>
> Andrew
>
>
> On 13/12/06, Nikolaj Hald Nielsen <nhnfreespirit at gmail.com> wrote:
> > Come to think of it... Now I had just managed to get the Magnatune
> > browser to look more or less like the Collection browser and now I'm
> > stuck far behind again... :-P
> >
> > Oh well, this might be a good time to do a cover cache for Magnatune
> > albums and add something simmilar to the Magnatune browser. Then I can
> > fix the "Add covers to Magnatune purchases" while I am at it. :-)
> >
> > - Nikolaj
> >
> > On 12/13/06, Robert Hogan <robert at roberthogan.net> wrote:
> > >
> > > yes, please keep this in some form or other. maybe a cd case effect around the
> > > cover? the edges definitely need a bit of softening.
> > >
> > > On Wednesday 13 December 2006 18:25, Nikolaj Hald Nielsen wrote:
> > > > This absolutely rocks! Nice one!
> > > >
> > > > - Nikolaj
> > > >
> > > > On 12/13/06, Andrew Turner <andrewturner512 at googlemail.com> wrote:
> > > > > http://www.srcf.ucam.org/~ajt60/amarok/covercollection.png
> > > > >
> > > > > On 13/12/06, Seb Ruiz <me at sebruiz.net> wrote:
> > > > > > awesome. anybody want to send me a screen shot of this baby?
> > > > > >
> > > > > > cheers,
> > > > > > seb
> > > > > >
> > > > > > On 13/12/06, Andrew Turner <andrewturner512 at googlemail.com> wrote:
> > > > > > > Fixed in 613259. Wouldn't want to spoil your holiday.
> > > > > > >
> > > > > > > andrewt512
> > > > > > >
> > > > > > > On 13/12/06, Seb Ruiz <me at sebruiz.net> wrote:
> > > > > > > > Should really use a query builder statement here - raw sql
> > > > > > > > statements outside of the collectiondb is bad! (i know, cat calling
> > > > > > > > the kettle black :)
> > > > > > > >
> > > > > > > > cya!
> > > > > > > >
> > > > > > > > seb, in turkey!
> > > > > > > >
> > > > > > > > On 12/12/06, Mark Kretschmann <markey at web.de> wrote:
> > > > > > > > > SVN commit 612787 by markey:
> > > > > > > > >
> > > > > > > > > Show album covers in collection browser. Experimental patch by
> > > > > > > > > Trever Fischer <wm161 at wm161.net>.
> > > > > > > > >
> > > > > > > > > I think this is pretty cool. Maybe we should limit size of the
> > > > > > > > > images though?
> > > > > > > > >
> > > > > > > > > BUG: 91044
> > > > > > > > > CCMAIL: amarok at kde.org
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > M +19 -0 collectionbrowser.cpp
> > > > > > > > > M +2 -0 collectionbrowser.h
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --- trunk/extragear/multimedia/amarok/src/collectionbrowser.cpp
> > > > > > > > > #612786:612787 @@ -1490,7 +1490,26 @@
> > > > > > > > > }
> > > > > > > > > }
> > > > > > > > >
> > > > > > > > > +void
> > > > > > > > > +CollectionItem::setPixmap(int column, const QPixmap & pix)
> > > > > > > > > +{
> > > > > > > > > + if ( m_cat == IdAlbum ) {
> > > > > > > > > + QString album = text(0);
> > > > > > > > > + QStringList values =
> > > > > > > > > + CollectionDB::instance()->query ( QString (
> > > > > > > > > + "SELECT DISTINCT artist.name FROM artist, album,
> > > > > > > > > tags " + "WHERE artist.id = tags.artist AND
> > > > > > > > > tags.album = album.id " + "AND album.name = '%1';"
> > > > > > > > > )
> > > > > > > > > + .arg( CollectionDB::instance()->escapeString(
> > > > > > > > > album ) ) ); + if ( !values.isEmpty() )
> > > > > > > > > + QListViewItem::setPixmap( column, QPixmap(
> > > > > > > > > CollectionDB::instance()->albumImage( values[0], album ) ) ); +
> > > > > > > > > else
> > > > > > > > > + QListViewItem::setPixmap( column, QPixmap(
> > > > > > > > > CollectionDB::instance()->notAvailCover() ) ); + } else
> > > > > > > > > + QListViewItem::setPixmap( column, pix );
> > > > > > > > > +}
> > > > > > > > >
> > > > > > > > > +
> > > > > > > > > void
> > > > > > > > > CollectionView::fetchCover() //SLOT
> > > > > > > > > {
> > > > > > > > > --- trunk/extragear/multimedia/amarok/src/collectionbrowser.h
> > > > > > > > > #612786:612787 @@ -165,6 +165,8 @@
> > > > > > > > > inline bool isUnknown() {return m_isUnknown;}
> > > > > > > > > inline bool isSampler() {return m_isSampler;}
> > > > > > > > >
> > > > > > > > > + virtual void setPixmap(int column, const QPixmap & pix);
> > > > > > > > > +
> > > > > > > > > static QPixmap *star();
> > > > > > > > > static QPixmap *smallStar();
> > > > > > > > >
> > > > > > > > > _______________________________________________
> > > > > > > > > Amarok mailing list
> > > > > > > > > Amarok at kde.org
> > > > > > > > > https://mail.kde.org/mailman/listinfo/amarok
> > > > > > > >
> > > > > > > > --
> > > > > > > > http://www.sebruiz.net/
> > > > > > > > _______________________________________________
> > > > > > > > Amarok mailing list
> > > > > > > > Amarok at kde.org
> > > > > > > > https://mail.kde.org/mailman/listinfo/amarok
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > Amarok mailing list
> > > > > > > Amarok at kde.org
> > > > > > > https://mail.kde.org/mailman/listinfo/amarok
> > > > > >
> > > > > > --
> > > > > > http://www.sebruiz.net/
> > > > > > _______________________________________________
> > > > > > Amarok mailing list
> > > > > > Amarok at kde.org
> > > > > > https://mail.kde.org/mailman/listinfo/amarok
> > > > >
> > > > > _______________________________________________
> > > > > Amarok mailing list
> > > > > Amarok at kde.org
> > > > > https://mail.kde.org/mailman/listinfo/amarok
> > > >
> > > > _______________________________________________
> > > > Amarok mailing list
> > > > Amarok at kde.org
> > > > https://mail.kde.org/mailman/listinfo/amarok
> > >
> > > --
> > >
> > > KlamAV - An Anti-Virus Manager for KDE - http://www.klamav.net
> > > TorK - A Tor Controller For KDE - http://tork.sf.net
> > > _______________________________________________
> > > Amarok mailing list
> > > Amarok at kde.org
> > > https://mail.kde.org/mailman/listinfo/amarok
> > >
> > _______________________________________________
> > Amarok mailing list
> > Amarok at kde.org
> > https://mail.kde.org/mailman/listinfo/amarok
> >
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>
More information about the Amarok
mailing list