D28165: Fix compatibility with modern MySQL

Victor Mataré noreply at phabricator.kde.org
Wed Mar 25 02:49:40 GMT 2020


vmatare updated this revision to Diff 78425.
vmatare marked an inline comment as done.
vmatare added a comment.


  Another attempt at a simple solution that works with all versions of MariaDB and MySQL. This one comes with the added cost of including the full `mysql.h` because that seems to be the only consistently supplied drop-in header by MariaDB. Other solutions would involve additional CMake hackery to distinguish between MariaDB and MySQL, but for the sake of sanity, let's sacrifice compilation time for simplicity here.
  
  Please test again, and thanks a lot for the review so far.

REPOSITORY
  R181 Amarok

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28165?vs=78424&id=78425

REVISION DETAIL
  https://phabricator.kde.org/D28165

AFFECTED FILES
  src/core-impl/storage/sql/mysql-shared/MySqlStorage.h
  tests/core-impl/collections/CMakeLists.txt

To: vmatare
Cc: jfowkes, asturmlechner, wbauer, amarok-devel, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine, nhuisman, paul, domson, yaohanchen, malteveerman, markey, James, tbettler, Smar, ricktimmis, schweingruber, heikobecker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20200325/35591ae8/attachment-0001.html>


More information about the Amarok-devel mailing list