D24040: Don't delete whole folder when deleting a track
Heiko Becker
noreply at phabricator.kde.org
Thu Sep 19 17:51:20 BST 2019
heikobecker accepted this revision.
heikobecker added a comment.
All those regressions from f1ab8128fdd6b2360bfea8b0bef9b5c46b8d5e68 <https://phabricator.kde.org/R181:f1ab8128fdd6b2360bfea8b0bef9b5c46b8d5e68> :(
In D24040#534381 <https://phabricator.kde.org/D24040#534381>, @wbauer wrote:
> In D24040#534325 <https://phabricator.kde.org/D24040#534325>, @schweingruber wrote:
>
> > Looks OK. What is the status of the unit tests, though?
>
>
> But this isn't tested at all AFAICS.
No, it isn't. It probably should, but judging from a cursory look it's not that quick and easy to test because it's not "near" the public interface. Anyway, I think it's more important to get this fix in, than delaying it for adding a new test.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D24040
To: wbauer, #amarok, schweingruber, heikobecker
Cc: heikobecker, schweingruber, #amarok, amarok-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20190919/3aa6bba2/attachment.html>
More information about the Amarok-devel
mailing list