D24413: Fix Increase/Decrease Volume shortcuts

[Heiko Becker]

heikobecker added a comment.


  
  
  In D24413#542042 <https://phabricator.kde.org/D24413#542042>, @wbauer wrote:
  
  > In D24413#542035 <https://phabricator.kde.org/D24413#542035>, @ognarb wrote:
  >
  > > Since the method is only one line long, why not using lambda instead here?
  >
  >
  > Because I couldn't get it to compile successfully, I got this error:
  >  In lambda function passing 'const EngineController' as 'this' argument discards qualifiers
  
  
  I'm always easy to confuse about pointers and const, but isn't ec a const pointer to a const object? So calling ec->increaseVolume() as a non-const function) wouldn't really work outside a lambda either.
  
  What I'm not sure about is why it was done that way and why it does work with the new style connects.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D24413

To: wbauer, #amarok, schweingruber
Cc: heikobecker, schweingruber, ognarb, amarok-devel, #amarok
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20191020/6b7469cd/attachment.html>