D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> kcategorydrawer.cpp:88
> +        textRect.setTop(textRect.top() + 4);
> +        textRect.setLeft(textRect.left() + 8);
>          textRect.setHeight(fontMetrics.height());

Instead of using magic number, I would create a constant named padding.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, #kpublictransport, #amarok
Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20191008/bcf7c8ad/attachment.html>