D24413: Fix Increase/Decrease Volume shortcuts
Wolfgang Bauer
noreply at phabricator.kde.org
Fri Oct 4 14:21:49 BST 2019
wbauer created this revision.
wbauer added a reviewer: Amarok.
wbauer added a project: Amarok.
Herald removed a project: Amarok.
wbauer requested review of this revision.
REVISION SUMMARY
`EngineController::increaseVolume( int ticks )` and `EngineController::decreaseVolume( int ticks )` take an argument that specifies the amount by which to increase/decrease the volume.
But it gets called with 0 as argument when pressing the shortcut key, so the volume was not changed at all.
To make the keyboard shortcuts work, create new slots that don't take arguments and call the previous ones with the default value.
TEST PLAN
Press the increase or decrease volume shortcut keys (+ and - by default), the volume is actually changed now, before they had no effect.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D24413
AFFECTED FILES
src/EngineController.cpp
src/EngineController.h
src/MainWindow.cpp
To: wbauer, #amarok
Cc: amarok-devel, #amarok
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20191004/8259de1f/attachment.html>
More information about the Amarok-devel
mailing list