D24381: Register Play/Pause global shortcut again
Wolfgang Bauer
noreply at phabricator.kde.org
Thu Oct 3 10:02:49 BST 2019
wbauer created this revision.
wbauer added a reviewer: Amarok.
wbauer added a project: Amarok.
Herald removed a project: Amarok.
wbauer requested review of this revision.
REVISION SUMMARY
Commit 0b2b243b <https://phabricator.kde.org/R181:0b2b243b2b70471c32d282157624379da5214051> removed the call to `KGlobalAccel::setGlobalShortcut()` because it registered `Space` as global shortcut, which of course is a bad idea.
But that made it impossible to set up a global shortcut at all (and made an existing one have no effect).
To fix this, add it back and register an empty global shortcut, like the KDE4 code does.
TEST PLAN
A global shortcut for Play/Pause can again be set in systemsettings5->Shortcuts->Global Shortcuts (it doesn't have a key assigned by default), and pressing the key does work as expected afterwards even if Amarok's window is not active.
The local shortcut (`Space` by default) still works as well.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D24381
AFFECTED FILES
src/ActionClasses.cpp
To: wbauer, #amarok
Cc: amarok-devel, #amarok
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20191003/f19fe5b1/attachment.html>
More information about the Amarok-devel
mailing list