D21478: Fix passing local file paths on the command line

[Wolfgang Bauer]

wbauer marked an inline comment as done.
wbauer added inline comments.

INLINE COMMENTS

> wbauer wrote in App.cpp:280
> It does handle relative paths just fine, see the test plan. (I just tried `./foo.ogg` to be sure)
> QUrl::fromUserInput() passes the directory to QDir(), which assumes '.' if empty.
> 
> I just noticed that amarok has a "--cwd" command line option though (that is currently ignored AFAICS), it would probably be good to pass that instead.

> I just noticed that amarok has a "--cwd" command line option though (that is currently ignored AFAICS), it would probably be good to pass that instead.

Hm, the "--cwd" option is not even parsed correctly (the QCommandLineOption doesn't specify that it actually takes an argument, therefore it's always empty if set).

So I'll leave this patch as-is.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D21478

To: wbauer, #amarok, fvogt
Cc: fvogt, amarok-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20190529/2e46b113/attachment.html>