D13180: Switch to the Attica framework

Pino Toscano noreply at phabricator.kde.org
Mon May 28 20:56:11 UTC 2018


pino created this revision.
pino added a reviewer: Amarok.
Restricted Application added a subscriber: amarok-devel.
pino requested review of this revision.

REVISION SUMMARY
  Switch from the old version of Attica, libattica-ocsclient, to the
  frameworks version of Attica, adapting the code in the following ways:
  
  - manually load the providers using ProviderManager
  - switch to the currently working provider, i.e. the kde-look.org one
  - deal with non-const methods of Provider by copying it locally
  - use the different API of jobs
  - manually load the avatars (always with KIO), since Attica does not do that
  
  Sadly, there is no kde/opendesktop provider that seems to provide
  information on users at this time, so most of this is not tested much.
  (But then, for the same reason the old code is not usable either.)

TEST PLAN
  Builds fine

REPOSITORY
  R181 Amarok

BRANCH
  use-system-attica (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13180

AFFECTED FILES
  CMakeLists.txt
  src/App.cpp
  src/CMakeLists.txt
  src/aboutdialog/ExtendedAboutDialog.cpp
  src/aboutdialog/ExtendedAboutDialog.h
  src/aboutdialog/OcsPersonItem.cpp
  src/aboutdialog/OcsPersonItem.h
  src/aboutdialog/OcsPersonListWidget.cpp
  src/aboutdialog/OcsPersonListWidget.h

To: pino, #amarok
Cc: amarok-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20180528/3b8de8e5/attachment.html>


More information about the Amarok-devel mailing list