D11534: Some small changes and fixes

[Heiko Becker]

heikobecker added inline comments.

INLINE COMMENTS

> Logger.h:61
> +        template<class Object = QObject, class Func = void (QObject::*)(), class... FuncArgs>
> +        void newProgressOperation( KJob *job, const QString &text, Object *obj = nullptr, Func slot = nullptr, Qt::ConnectionType type = Qt::AutoConnection, FuncArgs... args )
> +        {

This line seems to cause a build error on FreeBSD, which uses clang (contrary to the Linux build):
"error: missing default argument on parameter 'args' void newProgressOperation( KJob *job, const QString &text, Object *obj = nullptr, Func slot = nullptr, Qt::ConnectionType type = Qt::AutoConnection, FuncArgs... args )

Full log: https://build.kde.org/job/Extragear%20amarok%20kf5-qt5%20FreeBSDQt5.9/38/console

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D11534

To: malteveerman, #amarok, markey
Cc: heikobecker, #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20180325/3e5c9204/attachment.html>