D11349: Reactivate wikipedia applet

[Mark Kretschmann]

markey requested changes to this revision.
markey added a comment.
This revision now requires changes to proceed.


  Generally this works for me now, but there are two more issues that I found:
  
  If the optional Qt5WebEngine is not found, we get a CMake error anyway:
  =======================================================================
  
    -- The following OPTIONAL packages have not been found:
    
     * Qt5WebEngine
       Needed by the wikipedia applet
     * LibLastFm, Enable Last.Fm service, including scrobbling, song submissions, and suggested song dynamic playlists, <http://cdn.last.fm/client/liblastfm-1.0.3.tar.gz>
     * Mygpo-qt5 (required version >= 1.0.9), A Qt/C++ library wrapping the gpodder.net Webservice., <http://wiki.gpodder.org/wiki/Libmygpo-qt>
       Synchronize podcast subscriptions with gpodder.net
    
    -- The following REQUIRED packages have not been found:
    
     * Qt5 (required version >= 5.8.0)
    
    CMake Error at /usr/share/cmake-3.9/Modules/FeatureSummary.cmake:459 (message):
      feature_summary() Error: REQUIRED package(s) are missing, aborting CMake
      run.
    Call Stack (most recent call first):
      CMakeLists.txt:260 (feature_summary)
  
  
  
  If Qt5WebEngine is found, but the qml-module-qtwebengine is not installed, then the build works, but at runtime the Wikipedia applet will be empty:
  ===================================================================================================================================================
  
    file:///home/mark/kde/share/kpackage/amarok/org.kde.amarok.wikipedia/contents/ui/main.qml:20:1: module "QtWebEngine" is not installed

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D11349

To: malteveerman, #amarok, markey
Cc: heikobecker, markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20180320/2ccea68a/attachment.html>