Review Request 122797: Fix Gpodder credential service without kwallet

[Giuseppe Silletti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122797/
-----------------------------------------------------------

(Updated Feb. 17, 2017, 8:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for Amarok.


Changes
-------

Submitted with commit 32de657700902551f600de836021361ef965bb36 by Heiko Becker on behalf of Giuseppe Silletti to branch master.


Repository: amarok


Description
-------

Before to fix this bug, the gpodder plugin had problems with saving username and password in plain text. 

There were two problems: 

1) A useless space for the variable m_ignoreWallet was saved in the config file 
2) The saving of the credential in plain text where made in the wrong way. 
Now it is called the function askAboutMissingKWallet(), that make the use see a dialog windows where is asked to save the credential in plain text. 
Credential are now saved in the textDialogYes slot.


Diffs
-----

  src/services/gpodder/GpodderServiceConfig.cpp 9098d59 

Diff: https://git.reviewboard.kde.org/r/122797/diff/


Testing
-------

It simply works now


Thanks,

Giuseppe Silletti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20170217/a733f7e6/attachment.html>