Review Request 130232: Fix crash during musicbrainz search

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130232/#review103636
-----------------------------------------------------------



Thanks for the patch. Someone familiar with the code should merge this to 'kf5' branch. It is not trivial, because of the port of the parser to QObject.

I locally tried an automatic merge. Not only did this fail, but it was also wrong because it reverted parts of those porting commits.

- Christoph Feck


On Aug. 23, 2017, 5:40 p.m., Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130232/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2017, 5:40 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 328359
>     https://bugs.kde.org/show_bug.cgi?id=328359
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> + Fixed search result appending process to prevent creation of invalid indices.
> + Added "Accept" header to musicbrainz request, because sometimes MusicBrainz returns response in JSON format instead of XML.
> 
> 
> Diffs
> -----
> 
>   src/musicbrainz/MusicBrainzFinder.h beb155166f 
>   src/musicbrainz/MusicBrainzFinder.cpp 9a1b3bb14a 
>   src/musicbrainz/MusicBrainzTagsItem.h 6852c9fd31 
>   src/musicbrainz/MusicBrainzTagsItem.cpp 0941a901bc 
>   src/musicbrainz/MusicBrainzTagsModel.h eaee7f8e90 
>   src/musicbrainz/MusicBrainzTagsModel.cpp 0ffb284055 
>   src/musicbrainz/MusicBrainzXmlParser.h c7f9e72c0e 
>   src/musicbrainz/MusicBrainzXmlParser.cpp 290a275aed 
> 
> Diff: https://git.reviewboard.kde.org/r/130232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Ivanov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20170823/56b5042c/attachment.html>