Review Request 129237: [amarok] Try port services to KF5

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129237/
-----------------------------------------------------------

Review request for Amarok.


Repository: amarok


Description
-------

I try to enable services in KF5 branch, amarok to be usable, but problems still present


Diffs
-----

  src/CMakeLists.txt e777540 
  src/MainWindow.cpp c8ca2fe 
  src/main.cpp c7e235b 
  src/services/ampache/AmpacheSettings.cpp 0056d02 
  src/services/gpodder/GpodderServiceSettings.cpp 34280c7 
  src/services/jamendo/JamendoService.cpp 709f668 
  src/services/lastfm/LastFmServiceSettings.cpp 4a79ce6 
  src/services/magnatune/MagnatuneCollectionLocation.cpp 4ec21e7 
  src/services/magnatune/MagnatuneDownloadDialog.cpp 05847a3 
  src/services/magnatune/MagnatuneInfoParser.cpp 143b942 
  src/services/magnatune/MagnatuneSettingsModule.cpp 702a16a 
  src/services/magnatune/MagnatuneStore.cpp 3441e40 
  src/services/mp3tunes/Mp3tunesSettingsModule.cpp 5cf5999 
  src/services/opmldirectory/OpmlDirectoryInfoParser.cpp ea44956 
  src/services/opmldirectory/OpmlDirectoryModel.cpp d58e17a 
  src/services/opmldirectory/OpmlDirectoryService.cpp 3f97bbf 

Diff: https://git.reviewboard.kde.org/r/129237/diff/


Testing
-------

"amarok_storage-mysqlserverstorage.desktop" has no desktop group, cannot construct a KPluginInfo object from it.
"amarok_storage-mysqlestorage.desktop" has no desktop group, cannot construct a KPluginInfo object from it.
"amarok_collection-mysqlcollection.desktop" has no desktop group, cannot construct a KPluginInfo object from it.

[Desktop Entry] presents, but still not working.

One more issue, application deadlocks at exit.


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20161021/feed145d/attachment.html>